Skip to content

CI: Use windows-2025-vs2026 in the GMT Dev Tests workflow#4653

Closed
weiji14 wants to merge 2 commits into
mainfrom
win-2025-vs2026
Closed

CI: Use windows-2025-vs2026 in the GMT Dev Tests workflow#4653
weiji14 wants to merge 2 commits into
mainfrom
win-2025-vs2026

Conversation

@weiji14

@weiji14 weiji14 commented May 23, 2026

Copy link
Copy Markdown
Member

Description of proposed changes

Xref https://github.blog/changelog/2026-05-14-github-actions-upcoming-image-migrations/#windows-2025-visual-studio-2026-image-migration

⚠️ the blogpost mentions:

The windows-latest and windows-2025 labels in GitHub Actions will be migrated to use Visual Studio 2026 by default. This change will be rolled out over a week beginning June 8, 2026 and will complete by June 15, 2026.

If you want to test the new image, update the runs-on: target in your YAML workflow file to the new label windows-2025-vs2026.

Note: This label is meant for testing only. After the migration, this label will point to the windows-2025 image.

So treat this PR as testing the change in advance only, otherwise we need to change it back to windows-2025 after mid-June.

Supersedes #3701

@weiji14 weiji14 added the run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR label May 23, 2026
@seisman

seisman commented Jun 9, 2026

Copy link
Copy Markdown
Member

There are no new failures related to the VS2026 update, so I think we're all set. This PR can be closed.

@weiji14

weiji14 commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

Yep, seeing the same 6 failing tests in CI on this branch, vs 6 on the main branch from 2 days ago. Specifically:

..\pygmt\tests\test_grdimage_image.py::test_grdimage_image_dataarray_unsupported_dtype[int8] FAILED [ 60%]
..\pygmt\tests\test_grdimage_image.py::test_grdimage_image_dataarray_unsupported_dtype[int64] FAILED [ 60%]
..\pygmt\tests\test_grdimage_image.py::test_grdimage_image_dataarray_unsupported_dtype[uint64] FAILED [ 60%]
..\pygmt\tests\test_grdview.py::test_grdview_facadepen_default_plane FAILED [ 65%]
..\pygmt\tests\test_solar.py::test_solar_terminators FAILED              [ 86%]
..\pygmt\tests\test_text.py::test_text_position_offset_with_line FAILED  [ 91%]

So ok to close.

@weiji14 weiji14 closed this Jun 9, 2026
@weiji14 weiji14 deleted the win-2025-vs2026 branch June 9, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@weiji14 @seisman